Re: [RFC PATCH 14/32] x86/fred: header file with FRED definitions

From: Peter Zijlstra
Date: Thu Dec 22 2022 - 08:04:37 EST


On Wed, Dec 21, 2022 at 02:58:06AM +0000, Li, Xin3 wrote:

> > > +/* Flags above the CS selector (regs->csl) */
> > > +#define FRED_CSL_ENABLE_NMI _BITUL(28)
> > > +#define FRED_CSL_ALLOW_SINGLE_STEP _BITUL(25)
> > > +#define FRED_CSL_INTERRUPT_SHADOW _BITUL(24)
> >
> > What's the state of IBT WAIT-FOR-ENDBR vs this? That really should also get a
> > high CS bit.
>
> FRED does provide more possibilities :)

That's not an answer. IBT has a clear defect and FRED *should* fix it.