Re: [PATCH 1/1] usb: xhci: Check endpoint is valid before dereferencing it

From: Greg KH
Date: Thu Dec 22 2022 - 01:46:40 EST


A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Thu, Dec 22, 2022 at 02:39:16PM +0800, Jimmy Hu wrote:
> The xhci_kill_endpoint_urbs() function was added in commit 50e8725e7c42 -
> 2014-03-04 xhci: Refactor command watchdog and fix split string. [Sarah
> Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx>]
> And then, it is called by xhci_hc_died() function added in d9f11ba9f107 -
> 2017-04-08 xhci: Rework how we handle unresponsive or hoptlug removed hosts
> [Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx>]

Ok, so which one do you think should be used?

> Sorry. I don't know if it should also be cc: stable kernels. I use scripts/
> get_maintainer.pl to get the list.
> =========
> $ scripts/get_maintainer.pl
> 0001-usb-xhci-Check-endpoint-is-valid-before-dereferencin.patch
> Mathias Nyman <mathias.nyman@xxxxxxxxx> (supporter:USB XHCI DRIVER)
> Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> (supporter:USB SUBSYSTEM)
> linux-usb@xxxxxxxxxxxxxxx (open list:USB XHCI DRIVER)
> linux-kernel@xxxxxxxxxxxxxxx (open list)
> =========

that tool has nothing to do with copying for stable kernels as the perl
script does not know if this is a bugfix or not, right? Please read
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

thanks,

greg k-h