Re: [PATCH v2] kbuild: treat char as always unsigned

From: Linus Torvalds
Date: Wed Dec 21 2022 - 13:53:11 EST


On Wed, Dec 21, 2022 at 9:19 AM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
>
> On Wed, Dec 21, 2022 at 09:06:41AM -0800, Linus Torvalds wrote:
> >
> > I think the real fix is to just remove that broken implementation
> > entirely, and rely on the generic one.
>
> Perfectly fine with me.

That got pushed out as commit 7c0846125358 ("m68k: remove broken
strcmp implementation") but it's obviously entirely untested. I don't
do m68k cross-compiles, much less boot tests.

Just FYI for everybody - I may have screwed something up for some very
non-obvious reason.

But it looked very obvious indeed, and I hate having buggy code that
is architecture-specific when we have generic code that isn't buggy.

Linus