Re: [PATCH v7 1/4] Documentation: fpga: dfl: Add documentation for DFHv1

From: matthew . gerlach
Date: Wed Dec 21 2022 - 11:52:12 EST




On Tue, 20 Dec 2022, Andy Shevchenko wrote:

On Tue, Dec 20, 2022 at 08:36:49AM -0800, matthew.gerlach@xxxxxxxxxxxxxxx wrote:
From: Matthew Gerlach <matthew.gerlach@xxxxxxxxxxxxxxx>

Add documentation describing the extensions provided by Version
1 of the Device Feature Header (DFHv1).

...

+Device Feature Header - Version 0
+===========================================

Shouldn't this be the same length as the title itself?
Have you run make htmldocs and kernel doc validator on
this file after your change? Also you can use rst2pdf
to see PDF rendering.

Yes, it should be the same as the title itself. I will change it accordingly. I ran "make htmldocs" and rst2pdf, and resulting html and pdf looked fine.

Thanks for the review,
Matthew Gerlach


Same to the other title.

--
With Best Regards,
Andy Shevchenko