RE: [PATCH v3 1/2] dt-bindings: pinctrl: add schema for NXP S32 SoCs
From: Andrei Stefanescu
Date: Wed Dec 21 2022 - 07:29:08 EST
Hi Chester,
> +patternProperties:
> + '-pins$':
Sorry, I missed this in the previous versions. Could you change it to '_pins' (underscore)? In our .dts files we use underscore in the names for pinctrl configuration nodes e.g. i2c4_pins, usbotg_pins.
> + patternProperties:
> + '-grp[0-9]$':
The same comment also applies here.
> + llce-can0-pins {
> + llce-can0-grp0 {
This should also change to something like:
llce_can0_pins {
llce_can0_grp0 {
...
}
}
Otherwise, this and PATCH 2/2 look good to me.
Best regards,
Andrei