Re: [PATCH net] net: openvswitch: release vport resources on failure

From: Michal Swiatkowski
Date: Wed Dec 21 2022 - 05:11:48 EST


On Tue, Dec 20, 2022 at 04:27:17PM -0500, Aaron Conole wrote:
> A recent commit introducing upcall packet accounting failed to properly
> release the vport object when the per-cpu stats struct couldn't be
> allocated. This can cause dangling pointers to dp objects long after
> they've been released.
>
> Cc: Eelco Chaudron <echaudro@xxxxxxxxxx>
> Cc: wangchuanlei <wangchuanlei@xxxxxxxxxx>
> Fixes: 1933ea365aa7 ("net: openvswitch: Add support to count upcall packets")
> Reported-by: syzbot+8f4e2dcfcb3209ac35f9@xxxxxxxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Aaron Conole <aconole@xxxxxxxxxx>
> ---
Looks good, thanks

Reviewed-by: Michal Swiatkowski <michal.swiatkowski@xxxxxxxxxxxxxxx>
> --
> 2.31.1
>