Re: [PATCH] vdpa_sim: use weak barriers

[Stefano Garzarella]

On Wed, Dec 21, 2022 at 02:21:46PM +0800, Jason Wang wrote:
> vDPA simulators are software emulated device, so let's switch to use
> weak barriers to avoid extra overhead in the driver.
>
> Signed-off-by: Jason Wang <jasowang@xxxxxxxxxx>
> ---
> drivers/vdpa/vdpa_sim/vdpa_sim.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

I was going to propose the same :-)

Reviewed-by: Stefano Garzarella <sgarzare@xxxxxxxxxx>

> diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c
> index b071f0d842fb..eeaeaf43b476 100644
> --- a/drivers/vdpa/vdpa_sim/vdpa_sim.c
> +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c
> @@ -68,7 +68,7 @@ static void vdpasim_queue_ready(struct vdpasim *vdpasim, unsigned int idx)
> 	struct vdpasim_virtqueue *vq = &vdpasim->vqs[idx];
>
> 	vringh_init_iotlb(&vq->vring, vdpasim->dev_attr.supported_features,
> -			  VDPASIM_QUEUE_MAX, false,
> +			  VDPASIM_QUEUE_MAX, true,
> 			  (struct vring_desc *)(uintptr_t)vq->desc_addr,
> 			  (struct vring_avail *)
> 			  (uintptr_t)vq->driver_addr,
> --
> 2.25.1