Re: [PATCH] cgroup/cpuset: no need to explicitly init a global static variable

From: Daniel Vacek
Date: Wed Dec 21 2022 - 03:51:10 EST


On Tue, Dec 20, 2022 at 5:59 PM Waiman Long <longman@xxxxxxxxxx> wrote:
>
> On 12/20/22 10:14, Daniel Vacek wrote:
> > cpuset_rwsem is a static variable. It's initialized at build time and so
> > there's no need for explicit runtime init leaking one percpu int.
>
> It will be clearer if you mention that DEFINE_STATIC_PERCPU_RWSEM() is
> used to set up cpuset_rwsem at build time. Other than that, the patch
> looks good to me.

That's true. I only figured later.
Whoever is going to apply it, feel free to amend the message if you like.

--nX

> Cheers,
> Longman
>