Re: [Patch v1 01/10] memory: tegra: add interconnect support for DRAM scaling in Tegra234

[Sumit Gupta]

On 21/12/22 06:25, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
>
>
> 20.12.2022 19:02, Sumit Gupta пишет:
> > +static int tegra234_mc_icc_set(struct icc_node *src, struct icc_node *dst)
> > +{
> > +     struct tegra_mc *mc = icc_provider_to_tegra_mc(dst->provider);
> > +     struct tegra_icc_node *tnode = src->data;
> > +
> > +     /*
> > +      * Same Src and Dst node will happen during boot from icc_node_add().
> > +      * This can be used to pre-initialize and set bandwidth for all clients
> > +      * before their drivers are loaded. We are skipping this case as for us,
> > +      * the pre-initialization already happened in Bootloader(MB2) and BPMP-FW.
> > +      */
> > +     if (src->id == dst->id)
> > +             return 0;
> > +
> > +     if (tnode->node)
> > +             mc->curr_tnode = tnode;
> > +     else
> > +             pr_err("%s, tegra_icc_node is null\n", __func__);
>
> The tnode->node can't be NULL.

Ok, will remove the check.