Re: [Patch v1 01/10] memory: tegra: add interconnect support for DRAM scaling in Tegra234

From: Sumit Gupta
Date: Wed Dec 21 2022 - 02:54:56 EST




On 20/12/22 23:36, Dmitry Osipenko wrote:
External email: Use caution opening links or attachments


20.12.2022 19:02, Sumit Gupta пишет:
+ if (tegra_bpmp_mrq_is_supported(emc->bpmp, MRQ_BWMGR_INT)) {
+ err = tegra_emc_interconnect_init(emc);
+ if (!err)
+ return err;

"return err" doesn't sound good

+ dev_err(&pdev->dev, "tegra_emc_interconnect_init failed:%d\n", err);
+ goto put_bpmp;

Move error message to tegra_emc_interconnect_init()
Ok, will change.