Re: [EXTERNAL] Re: [PATCH] arm64: dts: ti: k3-j721s2: Add support for ADC nodes

[Bhavya Kapoor]

On 20/12/22 16:20, Krzysztof Kozlowski wrote:
> On 20/12/2022 11:12, Bhavya Kapoor wrote:
> > J721s2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes
> > for 8 channel ADCs for J721s2 SoC.
> >
> > Signed-off-by: Bhavya Kapoor <b-kapoor@xxxxxx>
> > ---
> >   .../dts/ti/k3-j721s2-common-proc-board.dts    | 14 +++++++
> >   .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi     | 42 ++++++++++++++++++-
> >   2 files changed, 55 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
> > index a7aa6cf08acd..67593aa69327 100644
> > --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
> > +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
> > @@ -309,3 +309,17 @@ &mcu_mcan1 {
> >   	pinctrl-0 = <&mcu_mcan1_pins_default>;
> >   	phys = <&transceiver2>;
> >   };
> > +
> > +&tscadc0 {
> > +	status = "okay";
> > +	adc {
> > +		ti,adc-channels = <0 1 2 3 4 5 6 7>;
> > +	};
> > +};
> > +
> > +&tscadc1 {
> > +	status = "okay";
> > +	adc {
> > +		ti,adc-channels = <0 1 2 3 4 5 6 7>;
> > +	};
> > +};
> > \ No newline at end of file
> This is a friendly reminder during the review process.
>
> It seems my previous comments were not fully addressed. Maybe my
> feedback got lost between the quotes, maybe you just forgot to apply it.
> Please go back to the previous discussion and either implement all
> requested changes or keep discussing them.
>
> Thank you.
>
> Best regards,
> Krzysztof

Hi , I thought i did addressed the feedback since tscadc is just a 
wrapper node.

The actual adc node is inside of tscadc node.