Re: [PATCH v5 1/3] fanotify: Ensure consistent variable type for response

From: Paul Moore
Date: Tue Dec 20 2022 - 18:31:15 EST


On Mon, Dec 12, 2022 at 9:06 AM Richard Guy Briggs <rgb@xxxxxxxxxx> wrote:
>
> The user space API for the response variable is __u32. This patch makes
> sure that the whole path through the kernel uses u32 so that there is
> no sign extension or truncation of the user space response.
>
> Suggested-by: Steve Grubb <sgrubb@xxxxxxxxxx>
> Link: https://lore.kernel.org/r/12617626.uLZWGnKmhe@x2
> Signed-off-by: Richard Guy Briggs <rgb@xxxxxxxxxx>
> ---
> fs/notify/fanotify/fanotify.h | 2 +-
> fs/notify/fanotify/fanotify_user.c | 6 +++---
> include/linux/audit.h | 6 +++---
> kernel/auditsc.c | 2 +-
> 4 files changed, 8 insertions(+), 8 deletions(-)

Acked-by: Paul Moore <paul@xxxxxxxxxxxxxx> (audit)

--
paul-moore.com