Re: [PATCH v3 1/1] i2c: Set pinctrl recovery info to device pinctrl

From: Hawa, Hanna
Date: Tue Dec 20 2022 - 14:33:38 EST




On 12/20/2022 9:18 PM, Andy Shevchenko wrote:
How you suggest to simplify this?
Using Elvis operator, which is ?:.

Are you refer to use 'return dev->pins && dev->pins->p ?: NULL;' ?
Can't use Elvis operator in this way, because it will return the result of 'dev->pins && dev->pins->p' and not the value of 'dev->pins->p'


I can use 'return dev->pins ? dev->pins->p ?: dev->pins->p : NULL;'
Have you even try to compile this?
Yup, the code compiled, but i think the first suggestion is more readable.