Re: [PATCH 2/2] ACPI: x86: s2idle: Stop using AMD specific codepath for Rembrandt+

From: francois@xxxxxxx
Date: Tue Dec 20 2022 - 12:54:17 EST


Am Thu, Dec 15, 2022 at 01:16:16PM -0600 schrieb Mario Limonciello:
> After we introduced a module parameter and quirk infrastructure for > picking the Microsoft GUID over the SOC vendor GUID we discovered >
that lots and lots of systems are getting this wrong. > > The table
continues to grow, and is becoming unwieldy. > > We don't really have
any benefit to forcing vendors to populate the > AMD GUID. This is just
extra work, and more and more vendors seem > to mess it up. As the
Microsoft GUID is used by Windows as well, > it's very likely that it
won't be messed up like this. > > So drop all the quirks forcing it and
the Rembrandt behavior. This > means that Cezanne or later effectively
only run the Microsoft GUID > codepath with the exception of HP
Elitebook 8*5 G9. > > Fixes: fd894f05cf30 ("ACPI: x86: s2idle: If a new
AMD _HID is missing assume Rembrandt") > Cc: stable@xxxxxxxxxxxxxxx #
6.1 > Reported-by: Benjamin Cheng <ben@xxxxxxxxx> > Reported-by:
bilkow@xxxxxxxxxxxx > Reported-by: Paul <paul@xxxxxxxxxx> > Link:
https://gitlab.freedesktop.org/drm/amd/-/issues/2292 > Link:
https://bugzilla.kernel.org/show_bug.cgi?id=216768 > Signed-off-by:
Mario Limonciello <mario.limonciello@xxxxxxx> Tested-by: François ARMAND <francois@xxxxxxx>
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2307

Regards - and thanks for the help Mario!
François