Re: [PATCH 1/5] gpiolib: of: remove of_gpio_count()

From: Andy Shevchenko
Date: Tue Dec 20 2022 - 08:52:03 EST


On Mon, Dec 19, 2022 at 11:20:12AM -0800, Dmitry Torokhov wrote:
> There are no more users of of_gpio_count() in the mainline kernel,
> remove it.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> ---
>
> After 6.2-rc1 there should be no more users of the APIs mentioned in
> this series.

I believe you probably want to have this patch applied immediately to the GPIO
subsystem after v6.2-rc1 to avoid new users.

> include/linux/of_gpio.h | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/include/linux/of_gpio.h b/include/linux/of_gpio.h
> index 6db627257a7b..39f16a960565 100644
> --- a/include/linux/of_gpio.h
> +++ b/include/linux/of_gpio.h
> @@ -105,17 +105,6 @@ static inline int of_gpio_named_count(const struct device_node *np,
> return of_count_phandle_with_args(np, propname, "#gpio-cells");
> }
>
> -/**
> - * of_gpio_count() - Count GPIOs for a device
> - * @np: device node to count GPIOs for
> - *
> - * Same as of_gpio_named_count, but hard coded to use the 'gpios' property
> - */
> -static inline int of_gpio_count(const struct device_node *np)
> -{
> - return of_gpio_named_count(np, "gpios");
> -}
> -
> static inline int of_get_gpio_flags(const struct device_node *np, int index,
> enum of_gpio_flags *flags)
> {
> --
> 2.39.0.314.g84b9a713c41-goog
>

--
With Best Regards,
Andy Shevchenko