Re: [PATCH v4 1/4] dt-bindings: arm-smmu: Document smmu-500 binding for SM6125

From: Krzysztof Kozlowski
Date: Tue Dec 20 2022 - 04:56:46 EST


On 19/12/2022 20:28, Marijn Suijten wrote:
> On 2022-12-19 10:09:03, Krzysztof Kozlowski wrote:
>> On 19/12/2022 10:07, Krzysztof Kozlowski wrote:
>>> On 16/12/2022 22:58, Marijn Suijten wrote:
>>>> From: Martin Botka <martin.botka@xxxxxxxxxxxxxx>
>>>>
>>>> Document smmu-500 compatibility with the SM6125 SoC.
>>>>
>>>
>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>>
>> Wait, not entirely... no constraints for clocks and regs?
>
> Quite odd that there is no warning for my DT patch as it clearly
> requires at least one clock...
>
> Irrespective of that downstream doesn't define any (nor power domains).
> How should we proceed?

Binding now has constraints for clocks so at least that should be added
to your variant.

Best regards,
Krzysztof