Re: [RFC][PATCH 03/12] cyrpto/b128ops: Remove struct u128

From: Eric Biggers
Date: Tue Dec 20 2022 - 00:52:13 EST


On Mon, Dec 19, 2022 at 04:35:28PM +0100, Peter Zijlstra wrote:
> cyrpto/b128ops: Remove struct u128

cyrpto => crypto

> Per git-grep u128_xor() and its related struct u128 are unused except
> to implement {be,le}128_xor(). Remove them to free up the namespace.

There's still a reference to u128 in drivers/crypto/vmx/ghash.c. But, it's only
dereferenced by assembly code, so it should keep working even if u128 gets
redefined to a native int. I don't speak PowerPC, so I'm not sure what the
"correct" type is there.

- Eric