Re: [PATCH] f2fs: maintain discard in separated file

[Chao Yu]

On 2022/12/17 21:23, Yangtao Li wrote:
> This patch moves discard related code from segment.c into discard.c
> since discard is independent feature, and it's better to maintain
> them in separated place.
>
> There is no functionality change.

Please check Jaegeuk's comments on similar patch:

https://lore.kernel.org/linux-f2fs-devel/20180426160819.GI68594@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/

> Signed-off-by: Yangtao Li <frank.li@xxxxxxxx>
> ---
>   fs/f2fs/Makefile  |    2 +-
>   fs/f2fs/discard.c | 1271 +++++++++++++++++++++++++++++++++++++++++++++
>   fs/f2fs/f2fs.h    |   37 +-
>   fs/f2fs/segment.c | 1268 +-------------------------------------------
>   4 files changed, 1317 insertions(+), 1261 deletions(-)
>   create mode 100644 fs/f2fs/discard.c
>
> diff --git a/fs/f2fs/Makefile b/fs/f2fs/Makefile
> index 8a7322d229e4..3d2874633db0 100644
> --- a/fs/f2fs/Makefile
> +++ b/fs/f2fs/Makefile
> @@ -3,7 +3,7 @@ obj-$(CONFIG_F2FS_FS) += f2fs.o
>   
>   f2fs-y		:= dir.o file.o inode.o namei.o hash.o super.o inline.o
>   f2fs-y		+= checkpoint.o gc.o data.o node.o segment.o recovery.o
> -f2fs-y		+= shrinker.o extent_cache.o sysfs.o
> +f2fs-y		+= shrinker.o extent_cache.o sysfs.o discard.o
>   f2fs-$(CONFIG_F2FS_STAT_FS) += debug.o
>   f2fs-$(CONFIG_F2FS_FS_XATTR) += xattr.o
>   f2fs-$(CONFIG_F2FS_FS_POSIX_ACL) += acl.o
> diff --git a/fs/f2fs/discard.c b/fs/f2fs/discard.c
> new file mode 100644
> index 000000000000..794f88fc729d
> --- /dev/null
> +++ b/fs/f2fs/discard.c
> @@ -0,0 +1,1271 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * f2fs discard support
> + *
> + * Copyright (c) 2022 Vivo Communication Technology Co.,Ltd.
> + * Author: Yangtao Li <frank.li@xxxxxxxx>

Oops, this is not a right way that changing copyright & anthor to vivo...

Thanks,