Re: [PATCH 3/3] crypto: tcrypt - yield at end of test

From: Herbert Xu
Date: Mon Dec 19 2022 - 22:55:56 EST


On Mon, Dec 19, 2022 at 02:37:33PM -0600, Robert Elliott wrote:
> Call cond_resched() to let the scheduler reschedule the
> CPU at the end of each test pass.
>
> If the kernel is configured with CONFIG_PREEMPT_NONE=y (or
> preempt=none is used on the kernel command line), the only
> time the scheduler will intervene is when cond_resched()
> is called. So, repeated calls to
> modprobe tcrypt mode=<something>
>
> hold the CPU for a long time.
>
> Signed-off-by: Robert Elliott <elliott@xxxxxxx>
> ---
> crypto/tcrypt.c | 1 +
> 1 file changed, 1 insertion(+)

I don't really see the point of this.

Cheers,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt