Re: [PATCH 0/2] ip/ip6_gre: Fix GRE tunnels not generating IPv6 link local addresses

[Chris Packham]

On 20/12/22 15:25, Chris Packham wrote:
> Hi Thomas,
>
> On 19/12/22 14:06, Thomas Winter wrote:
>> For our point-to-point GRE tunnels, they have IN6_ADDR_GEN_MODE_NONE
>> when they are created then we set IN6_ADDR_GEN_MODE_EUI64 when they
>> come up to generate the IPv6 link local address for the interface.
>> Recently we found that they were no longer generating IPv6 addresses.
>>
>> Also, non-point-to-point tunnels were not generating any IPv6 link
>> local address and instead generating an IPv6 compat address,
>> breaking IPv6 communication on the tunnel.
>>
>> These failures were caused by commit e5dd729460ca and this patch set
>> aims to resolve these issues.
>
> This appears to be a v2 of 
> https://lore.kernel.org/all/20221218215718.1491444-1-Thomas.Winter@xxxxxxxxxxxxxxxxxxx/#t 
> but you haven't said so in the subject nor have you included a 
> changelog in the patches or in the cover letter.
>
> Also for networking patches you should include either "net" or 
> "net-next" in the subject prefix. As this appears to be a bugfix "net" 
> is appropriate.
>
Took me a bit of looking but most of this stuff is covered by 
https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#netdev-faq
>>
>> Thomas Winter (2):
>>    ip/ip6_gre: Fix changing addr gen mode not generating IPv6 link local
>>      address
>>    ip/ip6_gre: Fix non-point-to-point tunnel not generating IPv6 link
>>      local address
>>
>>   net/ipv6/addrconf.c | 57 ++++++++++++++++++++++++---------------------
>>   1 file changed, 31 insertions(+), 26 deletions(-)
>>