Re: [PATCH v3 14/14] dt-bindings: rtc: pcf2127: add PCF2131

[Hugo Villeneuve]

On Mon, 19 Dec 2022 18:18:58 +0100
Bruno Thomsen <bruno.thomsen@xxxxxxxxx> wrote:

> Den man. 19. dec. 2022 kl. 17.25 skrev Hugo Villeneuve <hugo@xxxxxxxxxxx>:
> >
> > On Mon, 19 Dec 2022 10:14:10 +0100
> > Bruno Thomsen <bruno.thomsen@xxxxxxxxx> wrote:
> >
> > > Den tor. 15. dec. 2022 kl. 16.19 skrev Hugo Villeneuve <hugo@xxxxxxxxxxx>:
> > > >
> > > > From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
> > > >
> > > > Add support for new NXP RTC PCF2131.
> > > >
> > > > Signed-off-by: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
> > > > ---
> > > >  Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 4 +++-
> > > >  1 file changed, 3 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > > > index cde7b1675ead..a8f8c23da4d8 100644
> > > > --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > > > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > > > @@ -14,7 +14,9 @@ maintainers:
> > > >
> > > >  properties:
> > > >    compatible:
> > > > -    const: nxp,pcf2127
> > > > +    enum:
> > > > +      - nxp,pcf2127
> > > > +      - nxp,pcf2131
> > >
> > > The enum is incomplete as pcf2127_of_match struct also contains:
> > > nxp,pcf2129
> > > ncp,pca2129
> > >
> > > /Bruno
> >
> > Hi,
> > if I understand correctly, this means that the pca2129 and pcf2129 entries are already missing and should be added in a fix or a patch outside the scope of my new driver...
> >
> 
> Correct, I just noticed while doing review.

Hi,
I will send a separate patch very soon.

Thank you,
Hugo. V.


> > > >    reg:
> > > >      maxItems: 1
> > > > --
> > > > 2.30.2
> > > >
> > >
> >
> >
> > --
> > Hugo Villeneuve <hugo@xxxxxxxxxxx>
> 


-- 
Hugo Villeneuve <hugo@xxxxxxxxxxx>