Re: [PATCH v4 0/2] Make ILI9486 driver working with 16-bits SPI controllers

From: Neil Armstrong
Date: Mon Dec 19 2022 - 08:43:30 EST


Hi Kamlesh,

On 19/12/2022 10:02, Carlo Caione wrote:
This patchset is trying to fix problems seen on S905X boards when interfacing
with an ILI9486 equipped SPI panel.

I fully reviewed both patches, but I'd like a review from the maintainer,
can you have a look ?

Thanks,
Neil


To: Kamlesh Gurudasani <kamlesh.gurudasani@xxxxxxxxx>
To: David Airlie <airlied@xxxxxxxxx>
To: Daniel Vetter <daniel@xxxxxxxx>
To: Mark Brown <broonie@xxxxxxxxxx>
To: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
To: Kevin Hilman <khilman@xxxxxxxxxxxx>
To: Jerome Brunet <jbrunet@xxxxxxxxxxxx>
To: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
Cc: linux-kernel@xxxxxxxxxxxxxxx
Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
Cc: linux-amlogic@xxxxxxxxxxxxxxxxxxx
Signed-off-by: Carlo Caione <ccaione@xxxxxxxxxxxx>

---
Changes in v4:
- Removed NAK-ed patch from patchset
- Link to v3: https://lore.kernel.org/r/20221116-s905x_spi_ili9486-v3-0-59c6b58cbfe3@xxxxxxxxxxxx

Changes in v3:
- Added trailers
- Added new patch to use drm_aperture_remove_framebuffers()
- Link to v2: https://lore.kernel.org/r/20221116-s905x_spi_ili9486-v2-0-084c6e3cd930@xxxxxxxxxxxx

Changes in v2:
- Removed SPICC patch
- Reworked commit message
- Link to v1: https://lore.kernel.org/r/20221116-s905x_spi_ili9486-v1-0-630401cb62d5@xxxxxxxxxxxx

---
Carlo Caione (2):
drm/tiny: ili9486: Enable driver module autoloading
drm/tiny: ili9486: Do not assume 8-bit only SPI controllers

drivers/gpu/drm/tiny/ili9486.c | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
---
base-commit: 84e57d292203a45c96dbcb2e6be9dd80961d981a
change-id: 20221116-s905x_spi_ili9486-aed54ff3cb21

Best regards,