Re: [PATCH v2 5/7] mm/vmalloc: skip the uninitilized vmalloc areas

From: Baoquan He
Date: Mon Dec 19 2022 - 02:17:24 EST


On 12/17/22 at 12:07pm, Lorenzo Stoakes wrote:
> On Sat, Dec 17, 2022 at 09:54:33AM +0800, Baoquan He wrote:
> > @@ -3617,6 +3617,11 @@ long vread(char *buf, char *addr, unsigned long count)
> > if (!vm && !flags)
> > continue;
> >
> > + if (vm->flags & VM_UNINITIALIZED)
> > + continue;
>
> This comes immediately after asserting that vm _might be null_. This surely must become:-
>
> if (vm && vm->flags & VM_UNINITIALIZED)
> continue;

You are right, will fix it in v3. Thanks for careful reivewing.