RE: [RESEND v12 4/4] phy: freescale: imx8m-pcie: Add i.MX8MP PCIe PHY support

[Hongxing Zhu]

> -----Original Message-----
> From: Marek Vasut <marex@xxxxxxx>
> Sent: 2022年12月18日 3:47
> To: Hongxing Zhu <hongxing.zhu@xxxxxxx>; vkoul@xxxxxxxxxx;
> a.fatoum@xxxxxxxxxxxxxx; p.zabel@xxxxxxxxxxxxxx; l.stach@xxxxxxxxxxxxxx;
> bhelgaas@xxxxxxxxxx; lorenzo.pieralisi@xxxxxxx; robh@xxxxxxxxxx;
> shawnguo@xxxxxxxxxx; alexander.stein@xxxxxxxxxxxxxxx;
> richard.leitner@xxxxxxxxx
> Cc: linux-phy@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> linux-pci@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; dl-linux-imx
> <linux-imx@xxxxxxx>
> Subject: Re: [RESEND v12 4/4] phy: freescale: imx8m-pcie: Add i.MX8MP PCIe
> PHY support
> 
> On 10/13/22 03:47, Richard Zhu wrote:
> 
> Hi,
> 
> [...]
> 
> > @@ -238,6 +251,14 @@ static int imx8_pcie_phy_probe(struct
> platform_device *pdev)
> >   		return PTR_ERR(imx8_phy->reset);
> >   	}
> >
> > +	if (imx8_phy->drvdata->variant == IMX8MP) {
> > +		imx8_phy->perst =
> > +			devm_reset_control_get_exclusive(dev, "perst");
> > +		if (IS_ERR(imx8_phy->perst))
> > +			dev_err_probe(dev, PTR_ERR(imx8_phy->perst),
> 
> I just notice this , are we missing return here ?
> 
> That is ... return dev_err_probe(...) ?

Ooh, it's my fault. Thanks for your reminder.
One return should be here.
-                       dev_err_probe(dev, PTR_ERR(imx8_phy->perst),
+                       return dev_err_probe(dev, PTR_ERR(imx8_phy->perst),
Hi Vinod @vkoul@xxxxxxxxxx:
Should I re-summit one fix patch?

Best Regards
Richard Zhu

> 
> > +				      "Failed to get PCIE PHY PERST control\n");
> > +	}
> 
> [...]