Re: [PATCH 1/2] ip/ip6_gre: Fix changing addr gen mode not generating IPv6 link local address

From: Stephen Hemminger
Date: Sun Dec 18 2022 - 17:16:56 EST


On Mon, 19 Dec 2022 10:57:17 +1300
Thomas Winter <Thomas.Winter@xxxxxxxxxxxxxxxxxxx> wrote:

> + switch (dev->type) {
> + #if IS_ENABLED(CONFIG_IPV6_SIT)
> + case ARPHRD_SIT:
> + addrconf_sit_config(dev);
> + break;
> + #endif
> + #if IS_ENABLED(CONFIG_NET_IPGRE) || IS_ENABLED(CONFIG_IPV6_GRE)
> + case ARPHRD_IP6GRE:
> + case ARPHRD_IPGRE:
> + addrconf_gre_config(dev);
> + break;
> + #endif

Linux kernel style is to start any conditional compilation in first column

I.e.

#if IS_ENABLED(CONFIG_IPV6_SIT)

Not
#if IS_ENABLED(CONFIG_IPV6_SIT)