Re: [GIT PULL] perf tools changes for v6.2: 1st batch

From: Linus Torvalds
Date: Fri Dec 16 2022 - 14:48:48 EST


On Fri, Dec 16, 2022 at 8:36 AM Arnaldo Carvalho de Melo
<acme@xxxxxxxxxx> wrote:
>
> This time there is a trivial resolution of a merge conflict
> related to commit c302378bc157f6a7 ("libbpf: Hashmap interface update to
> allow both long and void* keys/values"), that touched tools/perf/ files.

Normally I'd ask you very sternly to please not resolve merge
conflicts for me, but since I just screwed up another merge due to
being on the road and not having done a full build test, I guess I
will just be quiet this time.

So the real reason for this email is that I get an error like this on
my laptop when trying to build the perf tools:

INSTALL libbpf_headers
Traceback (most recent call last):
File "util/setup.py", line 31, in <module>
from setuptools import setup, Extension
ImportError: No module named setuptools
cp: cannot stat 'python_ext_build/lib/perf*.so': No such file or directory
make[2]: *** [Makefile.perf:651: python/perf] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Makefile.perf:236: sub-make] Error 2
make: *** [Makefile:70: all] Error 2

and it's not new to this pull - I've seen it before and it's something
stupid I've done.

I think it's a missing package dependency that this laptop then hits.
But considering my previous merge failure, I'm not super-happy about
traveling with a laptop that then can't do this build test.

It would be lovely to have that package dependency - whatever it may
be - tested for explicitly. Hint hint.

Linus