Re: [PATCH 0/2] drm: Add component_match_add_of and convert users of drm_of_component_match_add

[Robin Murphy]

On 2022-12-16 17:08, Sean Anderson wrote:
> On 11/3/22 14:22, Sean Anderson wrote:
> > This series adds a new function component_match_add_of to simplify the
> > common case of calling component_match_add_release with
> > component_release_of and component_compare_of. There is already
> > drm_of_component_match_add, which allows for a custom compare function.
> > However, all existing users just use component_compare_of (or an
> > equivalent).
> >
> > I can split the second commit up if that is easier to review.
> >
> >
> > Sean Anderson (2):
> >    component: Add helper for device nodes
> >    drm: Convert users of drm_of_component_match_add to
> >      component_match_add_of
> >
> >   .../gpu/drm/arm/display/komeda/komeda_drv.c   |  6 ++--
> >   drivers/gpu/drm/arm/hdlcd_drv.c               |  9 +-----
> >   drivers/gpu/drm/arm/malidp_drv.c              | 11 +------
> >   drivers/gpu/drm/armada/armada_drv.c           | 10 ++++---
> >   drivers/gpu/drm/drm_of.c                      | 29 +++----------------
> >   drivers/gpu/drm/etnaviv/etnaviv_drv.c         |  4 +--
> >   .../gpu/drm/hisilicon/kirin/kirin_drm_drv.c   |  3 +-
> >   drivers/gpu/drm/ingenic/ingenic-drm-drv.c     |  3 +-
> >   drivers/gpu/drm/mediatek/mtk_drm_drv.c        |  4 +--
> >   drivers/gpu/drm/msm/msm_drv.c                 | 14 ++++-----
> >   drivers/gpu/drm/sti/sti_drv.c                 |  3 +-
> >   drivers/gpu/drm/sun4i/sun4i_drv.c             |  3 +-
> >   drivers/gpu/drm/tilcdc/tilcdc_external.c      | 10 ++-----
> >   drivers/iommu/mtk_iommu.c                     |  3 +-
> >   drivers/iommu/mtk_iommu_v1.c                  |  3 +-
> >   include/drm/drm_of.h                          | 12 --------
> >   include/linux/component.h                     |  9 ++++++
> >   sound/soc/codecs/wcd938x.c                    |  6 ++--
> >   18 files changed, 46 insertions(+), 96 deletions(-)
>
> ping?
>
> Should I send a v2 broken up like Mark suggested?

FWIW you'll need to rebase the IOMMU changes on 6.2-rc1 anyway - 
mtk_iommu stops using component_match_add_release() at all.

Thanks,
Robin.