Re: [PATCHv7 7/7] arm64: dts: rockchip: Add rock-5b board

[Nicolas Dufresne]

Hi Sebastian and Christopher,

Le jeudi 15 décembre 2022 à 19:30 +0100, Sebastian Reichel a écrit :
> From: Christopher Obbard <chris.obbard@xxxxxxxxxxxxx>
> 
> Add board file for the RK3588 Rock 5B board. This is a basic
> implementation which just brings up the eMMC and UART which is
> enough to successfully boot Linux.
> 
> The ethernet controller is connected via PCIe so support will
> come in a follow-up patch.
> 
> Signed-off-by: Christopher Obbard <chris.obbard@xxxxxxxxxxxxx>
> Reviewed-by: Michael Riesch <michael.riesch@xxxxxxxxxxxxxx>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/rockchip/Makefile         |  1 +
>  .../boot/dts/rockchip/rk3588-rock-5b.dts      | 44 +++++++++++++++++++
>  2 files changed, 45 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> 
> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> index 87a853435142..c5bdd0176ce0 100644
> --- a/arch/arm64/boot/dts/rockchip/Makefile
> +++ b/arch/arm64/boot/dts/rockchip/Makefile
> @@ -83,4 +83,5 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-odroid-m1.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-rock-3a.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-evb1-v10.dtb
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-rock-5b.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-rock-5a.dtb
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> new file mode 100644
> index 000000000000..baf46bd30b38
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> @@ -0,0 +1,44 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +
> +/dts-v1/;
> +
> +#include "rk3588.dtsi"
> +
> +/ {
> +	model = "Radxa Rock 5B Board";
> +	compatible = "radxa,rock-5b", "rockchip,rk3588";
> +
> +	aliases {
> +		mmc1 = &sdhci;

I have no useful knowledge, but it seems the mmc alias don't match the vendor.
When I run your branch on Rock5B, the EMMC endup on /dev/mmcblk1 (aka mmc1 alias
I think) while when I boot the vendor kernel, it is always mmcblk0 (aka mmc0
alias?). Perhaps the vendor didn't add aliases ?

There could also be mainline rules to number based on the boot order. In this
case, the difference would be acceptable, since SPL boot order is (usb?) > SD
Card > EMMC > SPI NOR. Though, the SPL is picked from the opposite order (spi,
emmc, sd card). Anyway, I'm just trying to express that I noticed a difference,
and its not guarantied to be a bug.

> +		serial2 = &uart2;
> +	};
> +
> +	chosen {
> +		stdout-path = "serial2:1500000n8";
> +	};
> +
> +	vcc5v0_sys: vcc5v0-sys-regulator {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vcc5v0_sys";
> +		regulator-always-on;
> +		regulator-boot-on;
> +		regulator-min-microvolt = <5000000>;
> +		regulator-max-microvolt = <5000000>;
> +	};
> +};
> +
> +&sdhci {
> +	bus-width = <8>;
> +	no-sdio;
> +	no-sd;
> +	non-removable;
> +	max-frequency = <200000000>;
> +	mmc-hs400-1_8v;
> +	mmc-hs400-enhanced-strobe;
> +	status = "okay";
> +};
> +
> +&uart2 {
> +	pinctrl-0 = <&uart2m0_xfer>;
> +	status = "okay";
> +};
> -- 
> 2.39.0
> 
>