Re: [PATCH v9 tty-next 2/4] serial: 8250_pci1xxxx: Add driver for quad-uart support

[Andy Shevchenko]

On Fri, Dec 16, 2022 at 10:31:38AM +0000, Tharunkumar.Pasumarthi@xxxxxxxxxxxxx wrote:
> > From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > Sent: Friday, December 16, 2022 3:09 PM
> > To: Tharunkumar Pasumarthi - I67821
> > <Tharunkumar.Pasumarthi@xxxxxxxxxxxxx>
> > Subject: Re: [PATCH v9 tty-next 2/4] serial: 8250_pci1xxxx: Add driver for
> > quad-uart support
> > 
> > > From this sequence, it seemed like, kernel takes care of freeing irq
> > > and calling pci_free_irq_vectors is not required.
> > 
> > Technically you are correct, but... read this discussion, and pay attention to
> > what Christoph said there:
> > 
> > https://lore.kernel.org/linux-serial/0250c46e-da6c-71f3-50ae-
> > b7c17fd0bd2c@xxxxxxxxxxx/
> 
> Okay, got it. Will use pci_free_irq_vectors.  Also, do you suggest using
> pci_enable_device instead of pcim_enable_device (to maintain consistency of
> using non managed APIs throughout driver)?

Up to you. I don't see any issues with devm_ and pcim_ APIs, you can get my
opinion from the very same discussion and also another which tried to pursue
pcim_alloc_irq_vectors().

-- 
With Best Regards,
Andy Shevchenko