Re: [PATCH] cma:tracing: Print alloc result in trace_cma_alloc_finish

[Steven Rostedt]

On Fri, 16 Dec 2022 19:47:59 +0800
Wenchao Hao <haowenchao@xxxxxxxxxx> wrote:

> On 2022/12/8 22:21, Wenchao Hao wrote:
> > The result of allocation is not printed in trace_cma_alloc_finish
> > now, while it's important to do it so we can set filters to catch
> > specific error on allocation or trigger some operations on specific
> > error.
> > 
> > Although we have printed the result in log, but the log is
> > conditional and could not be filtered by tracing event.
> > 
> > What's more, it introduce little overhead to print this result.
> > The result of allocation is named as errorno in trace.
> > 
> > Signed-off-by: Wenchao Hao <haowenchao@xxxxxxxxxx>
> > ---

> 
> pinging


>From a tracing point of view, I see nothing wrong with it.

Reviewed-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>

But I believe Andrew needs to take it.

-- Steve