Re: [PATCH] powerpc: Pass correct CPU reference to assembler

From: Christophe Leroy
Date: Fri Dec 16 2022 - 03:50:19 EST




Le 16/12/2022 à 09:38, Jan-Benedict Glaw a écrit :
> On Fri, 2022-12-16 16:07:25 +0800, kernel test robot <lkp@xxxxxxxxx> wrote:
>> Hi Christophe,
>>
>> I love your patch! Yet something to improve:
>
> [...]
>
>> If you fix the issue, kindly add following tag where applicable
>> | Reported-by: kernel test robot <lkp@xxxxxxxxx>
>>
>> All errors (new ones prefixed by >>):
>>
>> Assembler messages:
>>>> Error: invalid switch -mpowerpc
>>>> Error: unrecognized option -mpowerpc
>> make[2]: *** [scripts/Makefile.build:250: scripts/mod/empty.o] Error 2
>> make[2]: Target 'scripts/mod/' not remade because of errors.
>> make[1]: *** [Makefile:1271: prepare0] Error 2
>> make[1]: Target 'prepare' not remade because of errors.
>> make: *** [Makefile:231: __sub-make] Error 2
>> make: Target 'prepare' not remade because of errors.
>
> I see similar failures for many/most (about 4/5 of them) defconfigs.
> Needs some more testing, but I also think that's the route to go. :)

In fact for most CPUs we can do -mcpu=XXX and -Wa,-mXXX
But for the special case of -mcpu=powerpc, it is -Wa,-mppc.

I sent v2 a few minutes ago.

>
> IIRC there was another patch mentioned that needs to be applied as
> well, maybe that's already the needed fix along with this one?
>

The other patch is needed for ppc64e_defconfig, it is at
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/3fd60c2d8a28668a42b766b18362a526ef47e757.1670420281.git.christophe.leroy@xxxxxxxxxx/