Re: [PATCH v1 1/1] net: neigh: persist proxy config across link flaps

From: Mahesh Bandewar (महेश बंडेवार)
Date: Thu Dec 15 2022 - 00:34:38 EST


On Wed, Dec 14, 2022 at 8:49 PM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Mon, 12 Dec 2022 23:38:01 -0800 David Decotigny wrote:
> > From: David Decotigny <ddecotig@xxxxxxxxxx>
> >
> > Without this patch, the 'ip neigh add proxy' config is lost when the
> > cable or peer disappear, ie. when the link goes down while staying
> > admin up. When the link comes back, the config is never recovered.
> >
> > This patch makes sure that such an nd proxy config survives a switch
> > or cable issue.
>
> Hm, how does this square with the spirit of 859bd2ef1fc11 ?
>
Devid's (Decotigny) patch is adding the distinction between admin-down
from carrier-off which could be transient. So in my belief, it's
correcting / enhancing the behavior that David (Ahern) introduced but
we can hear from David himself :)

> Would be great to hear from David, IDK if he's around or off until
> next year.