Re: [PATCH 2/3] fs/ufs: Change the signature of ufs_get_page()

From: Al Viro
Date: Sun Dec 11 2022 - 17:42:36 EST


On Sun, Dec 11, 2022 at 10:31:10PM +0100, Fabio M. De Francesco wrote:
> out_put:
> ufs_put_page(page);
> -out:
> - return err;
> out_unlock:
> unlock_page(page);
> goto out_put;

Something strange has happened, all right - look at the situation
after that patch. You've got

out_put:
ufs_put_page(page);
out_unlock:
unlock_page(page);
goto out_put;

Which is obviously bogus.