Re: [PATCH 4/5] dt-bindings: arm: qcom: Add SM6115(P) and Lenovo Tab P11

From: Bhupesh Sharma
Date: Sat Dec 10 2022 - 10:58:22 EST


On Fri, 9 Dec 2022 at 01:44, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote:
>
> Document SM6115P, an APQ version of SM6115, which in turn is more or
> less a beefier version of SM4250.

Let's drop the 2nd part of the above statement. As we discussed on
irc, It suffices to say that SM6115P is the APQ version of SM6115.

I don't think that would require a respin. Maybe the commit message
can be fixed while applying this.

> Document Lenovo Tab P11 (J606F) as a SM6115P device.
>
> Add SM6115 to the msm-id list of shame.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/arm/qcom.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 27063a045bd0..0c7ad00586fa 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -62,6 +62,7 @@ description: |
> sdx65
> sm4250
> sm6115
> + sm6115p
> sm6125
> sm6350
> sm6375
> @@ -790,6 +791,12 @@ properties:
> - oneplus,billie2
> - const: qcom,sm4250
>
> + - items:
> + - enum:
> + - lenovo,j606f
> + - const: qcom,sm6115p
> + - const: qcom,sm6115
> +
> - items:
> - enum:
> - sony,pdx201
> @@ -931,6 +938,7 @@ allOf:
> - qcom,sdm845
> - qcom,sdx55
> - qcom,sdx65
> + - qcom,sm6115
> - qcom,sm6125
> - qcom,sm6350
> - qcom,sm7225
> --
> 2.38.1

Otherwise:
Reviewed-by: Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx>

Thanks.