Re: [PATCH 0/5] add s390 support to nolibc and rcutorture

From: Willy Tarreau
Date: Fri Dec 09 2022 - 10:29:16 EST


On Fri, Dec 09, 2022 at 07:03:25AM -0800, Paul E. McKenney wrote:
> On Fri, Dec 09, 2022 at 03:19:34PM +0100, Sven Schnelle wrote:
> > Hi,
> >
> > these patches add support for the s390 architecture both to nolibc
> > and rcutorture. Note that this only adds support for the 64 bit
> > version, no support for 31 bit (compat) is added. For nolibc it
> > includes one bugfix to make the fd_set datatype match the kernel
> > type.
>
> Nice!!!

indeed :-)

> The rcutorture patches look plausible to me, but I must defer to Willy
> Tarreau on the nolibc changes.

I had a very quick glance over them and nothing shocked me. I just want
to double-check the u32->long conversion with a careful eye but I'm happy
to see that your rcutorture binary continues its diet on more and more
architectures ;-)

Cheers,
Willy