Re: [PATCH v2 08/16] dt-bindings: soc: socionext: Add UniPhier system controller

[Kunihiko Hayashi]

On 2022/12/08 17:15, Krzysztof Kozlowski wrote:
> On 07/12/2022 06:53, Kunihiko Hayashi wrote:
> > Add devicetree binding schema for the system controller implemented on
> > Socionext Uniphier SoCs.
> >
> > This system controller has multiple functions such as clock control,
> > reset control, internal watchdog timer, thermal management, and so on.
> >
> > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>
> > ---
> >   .../socionext/socionext,uniphier-sysctrl.yaml | 105 ++++++++++++++++++
> >   MAINTAINERS                                   |   1 +
> >   2 files changed, 106 insertions(+)
> >   create mode 100644
> > Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sysctrl.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sysctrl.yaml
> > b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sysctrl.yaml
> > new file mode 100644
> > index 000000000000..c1b7cec8def4
> > --- /dev/null
> > +++
> > b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sysctrl.yaml
> > @@ -0,0 +1,105 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id:
> > http://devicetree.org/schemas/soc/socionext/socionext,uniphier-sysctrl.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Socionext UniPhier system controller
> > +
> > +maintainers:
> > +  - Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>
> > +
> > +description: |+
> > +  System controller implemented on Socionext UniPhier SoCs has multiple
> > +  functions such as clock control, reset control, internal watchdog
> > timer,
> > +  thermal management, and so on.
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +          - socionext,uniphier-ld4-sysctrl
> > +          - socionext,uniphier-pro4-sysctrl
> > +          - socionext,uniphier-pro5-sysctrl
> > +          - socionext,uniphier-pxs2-sysctrl
> > +          - socionext,uniphier-sld8-sysctrl
> > +          - socionext,uniphier-ld11-sysctrl
> > +          - socionext,uniphier-ld20-sysctrl
> > +          - socionext,uniphier-pxs3-sysctrl
> > +          - socionext,uniphier-nx1-sysctrl
> > +      - const: simple-mfd
> > +      - const: syscon
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +patternProperties:
> > +  "^clock-controller(@[0-9a-f]+)?$":
>
> I don't remember if we talked about this but: why do you include here
> unit address? All your bindings expect these take regmap from the parent
> and they do not have separate MMIO address space, so these should be
> properties, not pattern properties.

I thought this unit address was an option, however, there is no example
of the existing devicetree. It is no longer necessary.

> Same in places below.
>
> > +    $ref: /schemas/clock/socionext,uniphier-clock.yaml#
> > +
> > +  "^reset-controller(@[0-9a-f]+)?$":
> > +    $ref: /schemas/reset/socionext,uniphier-reset.yaml#
> > +
> > +  "^watchdog(@[0-9a-f]+)?$":
> > +    $ref: /schemas/watchdog/socionext,uniphier-wdt.yaml#
> > +
> > +  "^thermal-sensor(@[0-9a-f]+)?$":
> > +    $ref: /schemas/thermal/socionext,uniphier-thermal.yaml#

I'll drop the address patterns.

Thank you,

---
Best Regards
Kunihiko Hayashi