Re: [PATCH v4] perf jevents: Parse metrics during conversion

[Arnaldo Carvalho de Melo]

Em Wed, Dec 07, 2022 at 05:42:52PM +0000, John Garry escreveu:
> On 07/12/2022 17:40, Arnaldo Carvalho de Melo wrote:
> > Em Tue, Dec 06, 2022 at 09:59:08PM -0800, Ian Rogers escreveu:
> > > Currently the 'MetricExpr' json value is passed from the json
> > > file to the pmu-events.c. This change introduces an expression
> > > tree that is parsed into. The parsing is done largely by using
> > > operator overloading and python's 'eval' function. Two advantages
> > > in doing this are:
> > John, what tag can I get from you? 😄
> > 
> > - Arnaldo
> Sure,
> Reviewed-by: John Garry <john.g.garry@xxxxxxxxxx>

Thanks a lot!

- Arnaldo