Re: [PATCH 431/606] mfd: khadas-mcu: Convert to i2c's .probe_new()

[Uwe Kleine-König]

Hello Lee,

On Wed, Dec 07, 2022 at 01:34:01PM +0000, Lee Jones wrote:
> On Wed, 07 Dec 2022, Lee Jones wrote:
> > On Wed, 07 Dec 2022, Uwe Kleine-König wrote:
> > > I see you added my commits to your tree now, however there is a problem:
> > > 
> > >   [...]
> > > 
> > > That means that the commit introducing i2c_client_get_device_id() isn't
> > > an ancestor of the commits that make use of the new function. So
> > > 63909fec136e (which is the first commit making use of the new function)
> > > likely won't compile:
> > > 
> > > 	$ git grep i2c_client_get_device_id 63909fec136e
> > > 	63909fec136e:drivers/mfd/adp5520.c:     const struct i2c_device_id *id = i2c_client_get_device_id(client);
> > > 
> > > Starting with 7281458f4396 everything is fine again, but still this
> > > hurts a bisection.
> > 
> > Fair point - I'll rebase the my topic branch on top of Wolfram's.
> 
> Okay, try now.

Looks good now, thanks!

Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature