Re: [patch 1/3] VT: Add height parameter to con_font_get/set consw operations

[Jiri Slaby]

On 06. 12. 22, 21:39, Samuel Thibault wrote:
> Jiri Slaby, le mar. 06 déc. 2022 07:40:30 +0100, a ecrit:
> > On 05. 12. 22, 1:07, Samuel Thibault wrote:
> > > --- linux-6.0.orig/drivers/usb/misc/sisusbvga/sisusb_con.c
> > > +++ linux-6.0/drivers/usb/misc/sisusbvga/sisusb_con.c
> > ...
> > > @@ -1268,7 +1271,7 @@ sisusbcon_font_get(struct vc_data *c, st
> > >    	}
> > >    	/* Copy 256 chars only, like vgacon */
> > > -	memcpy(font->data, sisusb->font_backup, 256 * 32);
> > > +	memcpy(font->data, sisusb->font_backup, 256 * height);
> >
> > Have you tested this?
>
> Ah, no, I had assumed that this was for a specific arch. But actually I
> wasn't getting it because it depends on BROKEN.

Hmm, for two years... I will remove the con support completely next week 
if noone beats me to it.

thanks,
--
js
suse labs