Re: [PATCH] net: ipa: use sysfs_emit() to instead of scnprintf()

From: Jakub Kicinski
Date: Tue Dec 06 2022 - 21:53:43 EST


On Fri, 2 Dec 2022 16:20:16 -0600 Alex Elder wrote:
> On 12/2/22 2:42 AM, ye.xingchen@xxxxxxxxxx wrote:
> > From: ye xingchen <ye.xingchen@xxxxxxxxxx>
> >
> > Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> > should only use sysfs_emit() or sysfs_emit_at() when formatting the
> > value to be returned to user space.
>
> The buffer passed is non-null and the existing code properly
> limits the buffer to PAGE_SIZE.
>
> But... OK.
>
> Reviewed-by: Alex Elder <elder@xxxxxxxxxx>
>

Thanks! 38db82e2940 in net-next.