Re: [PATCH net-next v1 1/1] net: dsa: microchip: add stats64 support for ksz8 series of switches

From: Jakub Kicinski
Date: Tue Dec 06 2022 - 14:41:41 EST


On Mon, 5 Dec 2022 06:29:04 +0100 Oleksij Rempel wrote:
> + stats->rx_packets = raw->rx_bcast + raw->rx_mcast + raw->rx_ucast +
> + raw->rx_pause;
> + stats->tx_packets = raw->tx_bcast + raw->tx_mcast + raw->tx_ucast +
> + raw->tx_pause;

FWIW for normal netdevs / NICs the rtnl_link_stat pkts do not include
pause frames, normally. Otherwise one can't maintain those stats in SW
(and per-ring stats, if any, don't add up to the full link stats).
But if you have a good reason to do this - I won't nack..