Re: [PATCH net-next v3 0/2] dsa: lan9303: Move to PHYLINK

From: Vladimir Oltean
Date: Tue Dec 06 2022 - 13:58:46 EST


On Tue, Dec 06, 2022 at 12:34:58PM -0600, Jerry Ray wrote:
> This patch series moves the lan9303 driver to use the phylink
> api away from phylib.
>
> 1) adds port_max_mtu api support.
> 2) Replace .adjust_link with .phylink_get_caps dsa api

What does the max MTU have to do with phylink? What is it that makes
these two patches related?

>
> Clearing the Turbo Mode bit previously done in the adjust_link
> API is moved to the driver initialization immediately following
> the successful detection of a LAN93xx device. It is forced to a
> disabled state and never enabled.
>
> At this point, I do not see anything this driver needs from the other
> phylink APIs.
>
> Signed-off-by: Jerry Ray <jerry.ray@xxxxxxxxxxxxx>

You don't need to put your sign off on the cover letter.