Re: [PATCH v2] clk: qcom: rpmh: add support for SM6350 rpmh IPA clock

From: Bjorn Andersson
Date: Tue Dec 06 2022 - 13:34:01 EST


On Mon, Dec 05, 2022 at 09:05:30PM -0600, Alex Elder wrote:
> On 12/5/22 4:56 PM, Bjorn Andersson wrote:
> > On Fri, Dec 02, 2022 at 04:12:40PM -0600, Alex Elder wrote:
> > > From: Luca Weiss <luca.weiss@xxxxxxxxxxxxx>
> > >
> > > The IPA core clock is required for SM6350. Define it.
> > >
> > > [elder@xxxxxxxxxx: rebased with Dmitry's changes]
> > > Signed-off-by: Luca Weiss <luca.weiss@xxxxxxxxxxxxx>
>
> Sorry about that, I knew I was supposed to sign
> off and thought I had.
>
> You told me separately that this was sufficient:
>
> Signed-off-by: Alex Elder <elder@xxxxxxxxxx>
>
> If you want me to send a new version with the
> signoff just let me know. Thanks.
>

That works fine, thank you.
Bjorn

> -Alex
> >
> > Thanks for rebasing this Alex. But as you're handling the patch you need
> > to add your S-o-b; which will make sure your [] makes sense as well.
> >
> > Regards,
> > Bjorn
> >
> > > ---
> > > v2: This is now based on qualcomm/for-next.
> > >
> > > drivers/clk/qcom/clk-rpmh.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
> > > index 2c2ef4b6d130e..586a810c682ca 100644
> > > --- a/drivers/clk/qcom/clk-rpmh.c
> > > +++ b/drivers/clk/qcom/clk-rpmh.c
> > > @@ -606,6 +606,7 @@ static struct clk_hw *sm6350_rpmh_clocks[] = {
> > > [RPMH_LN_BB_CLK3_A] = &clk_rpmh_ln_bb_clk3_g4_ao.hw,
> > > [RPMH_QLINK_CLK] = &clk_rpmh_qlink_div4.hw,
> > > [RPMH_QLINK_CLK_A] = &clk_rpmh_qlink_div4_ao.hw,
> > > + [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw,
> > > };
> > > static const struct clk_rpmh_desc clk_rpmh_sm6350 = {
> > > --
> > > 2.34.1
> > >
>