Re: [PATCH v3] arm64: dts: qcom: sa8540p-ride: enable PCIe support

From: Johan Hovold
Date: Tue Dec 06 2022 - 10:51:33 EST


On Fri, Dec 02, 2022 at 07:09:18AM -0500, Brian Masney wrote:
> Add the vreg_l11a, pcie3a, pcie3a_phy, and tlmm nodes that are necessary
> in order to get PCIe working on the QDrive3.

> @@ -158,6 +186,31 @@ &remoteproc_nsp1 {
> status = "okay";
> };
>
> +&tlmm {
> + pcie3a_default: pcie3a-default-state {
> + perst-pins {
> + pins = "gpio151";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-pull-down;
> + };
> +
> + clkreq-pins {
> + pins = "gpio150";
> + function = "pcie3a_clkreq";
> + drive-strength = <2>;
> + bias-pull-up;
> + };
> +
> + wake-pins {
> + pins = "gpio56";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-pull-up;
> + };
> + };
> +};
> +

The pin configuration nodes typically go last after a

/* PINCTRL */

delimiter as this section tends to become rather long.

> &ufs_mem_hc {
> reset-gpios = <&tlmm 228 GPIO_ACTIVE_LOW>;

Johan