Re: [Patch net-next v2 01/13] net: dsa: microchip: ptp: add the posix clock support

From: Vladimir Oltean
Date: Tue Dec 06 2022 - 05:48:57 EST


On Tue, Dec 06, 2022 at 11:37:26AM +0100, Christian Eggers wrote:
> > v1 -> v2
> > - Deleted setting 8021_1as bit and added P2P bit in ksz_ptp_clock_register()
>
> did I miss the discussion about this change? I thought that the first goal is
> to use KSZ switches as a boundary clock which implies using the 802.1AS feature.
>
> Using the KSZ in P2P transparent clock mode IMHO requires writing the peer delays
> into switch registers (which needs to be implemented in a companion
> application/script for ptp4p).
>
> As far as I remember, there is also no support using ptp4l with 1-step transparent
> clock switches.

If it was in response to something I said, I just asked to add a comment
as to what the 802.1AS bit does, not to delete it...