Re: [PATCH] Linux: SPI: add Gigadevice part #

[Miquel Raynal]

Hi Vlim,

vlim@xxxxxxxxxxxxxx wrote on Tue, 6 Dec 2022 01:27:13 +0000:

> Hi, Michael,
> 
> I will redo the patch following this doc.
> At the meantime, can you point out a few mistakes that I am making so that I can correct it in the next submit.

Here are a few:
- The title is wrong (git log --oneline <file> for hints)
- The commit log is useless
- Don't make unrelated changes in your commit, one change == one commit
- Don't change how the code looks like for no reason or justification

And please avoid top posting when answering.

Good luck!

Thanks,
Miquèl

> 
> ________________________________
> From: Michael Walle <michael@xxxxxxxx>
> Sent: Monday, December 5, 2022 00:22
> To: Victor Lim <victorswlim@xxxxxxxxx>
> Cc: tudor.ambarus@xxxxxxxxxxxxx <tudor.ambarus@xxxxxxxxxxxxx>; p.yadav@xxxxxx <p.yadav@xxxxxx>; miquel.raynal@xxxxxxxxxxx <miquel.raynal@xxxxxxxxxxx>; richard@xxxxxx <richard@xxxxxx>; vigneshr@xxxxxx <vigneshr@xxxxxx>; linux-mtd@xxxxxxxxxxxxxxxxxxx <linux-mtd@xxxxxxxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx <linux-kernel@xxxxxxxxxxxxxxx>; vikhyat.goyal@xxxxxxx <vikhyat.goyal@xxxxxxx>; amit.kumar-mahapatra@xxxxxxx <amit.kumar-mahapatra@xxxxxxx>; alejandro.carmona@xxxxxxx <alejandro.carmona@xxxxxxx>; Vlim <vlim@xxxxxxxxxxxxxx>
> Subject: Re: [PATCH] Linux: SPI: add Gigadevice part #
> 
> [You don't often get email from michael@xxxxxxxx. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> 此为外部邮件，谨防钓鱼邮件，请注意邮件是否涉及敏感信息
> 
> This is an external email, beware of phishing emails. Please pay close attention to whether the email contains sensitive information
> 
> 
> Hi,
> 
> Am 2022-12-04 09:00, schrieb Victor Lim:
> > Edited gigadevice.c  
> 
> Please have a look at
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html
> 
> -michael