RE: [PATCH net v4] net: stmmac: Set MAC's flow control register to reflect current settings

From: Goh, Wei Sheng
Date: Mon Dec 05 2022 - 23:05:55 EST


Hi,

> -----Original Message-----
> From: Russell King <linux@xxxxxxxxxxxxxxx>
> Sent: Saturday, 3 December, 2022 1:24 AM
> To: Goh, Wei Sheng <wei.sheng.goh@xxxxxxxxx>
> Cc: Lobakin, Alexandr <alexandr.lobakin@xxxxxxxxx>; Giuseppe Cavallaro
> <peppe.cavallaro@xxxxxx>; Alexandre Torgue <alexandre.torgue@xxxxxx>;
> Jose Abreu <joabreu@xxxxxxxxxxxx>; David S . Miller
> <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>; Jakub
> Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>; Maxime
> Coquelin <mcoquelin.stm32@xxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; linux-
> stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Alexandre Torgue
> <alexandre.torgue@xxxxxxxxxxx>; Ong, Boon Leong
> <boon.leong.ong@xxxxxxxxx>; Voon, Weifeng <weifeng.voon@xxxxxxxxx>;
> Tan, Tee Min <tee.min.tan@xxxxxxxxx>; Ahmad Tarmizi, Noor Azura
> <noor.azura.ahmad.tarmizi@xxxxxxxxx>; Looi, Hong Aun
> <hong.aun.looi@xxxxxxxxx>
> Subject: Re: [PATCH net v4] net: stmmac: Set MAC's flow control register to
> reflect current settings
>
> On Mon, Nov 28, 2022 at 06:06:11AM +0000, Goh, Wei Sheng wrote:
> > Hi,
> >
> > > -----Original Message-----
> > > From: Lobakin, Alexandr <alexandr.lobakin@xxxxxxxxx> Any particular
> > > reason why you completely ignored by review comments to the v3[0]?
> > > I'd like to see them fixed or at least replied.
> > >
> > > [0] https://lore.kernel.org/netdev/20221123180947.488302-1-
> > > alexandr.lobakin@xxxxxxxxx
> > >
> > > Thanks,
> > > Olek
> >
> > Due to v4 is being accepted. Therefore I will submit a new patch to address
> your review comments.
> > Thanks and appreciate your effort for reviewing my patch.
>
> And on that very same subject, why did you ignore my review comments on
> v2?
>
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

Sorry I missed some of your comment. Will try to address them in the next submission.
Also thanks and appreciate your effort for reviewing my patch.