Re: [PATCH v4 net-next 8/9] dt-bindings: net: add generic ethernet-switch-port binding

From: Rob Herring
Date: Mon Dec 05 2022 - 16:49:09 EST



On Fri, 02 Dec 2022 12:45:58 -0800, Colin Foster wrote:
> The dsa-port.yaml binding had several references that can be common to all
> ethernet ports, not just dsa-specific ones. Break out the generic bindings
> to ethernet-switch-port.yaml they can be used by non-dsa drivers.
>
> Signed-off-by: Colin Foster <colin.foster@xxxxxxxxxxxxxxxx>
> Suggested-by: Vladimir Oltean <olteanv@xxxxxxxxx>
> Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
> ---
>
> v3 -> v4
> * Add Florian Reviewed tag
>
> v2 -> v3
> * Change dsa-port title from "DSA Switch port Device Tree Bindings"
> to "Generic DSA Switch port"
> * Add reference to ethernet-switch-port.yaml# in dsa-port.yaml
> * Change title of ethernet-switch-port.yaml from "Ethernet Switch
> port Device Tree Bindings" to "Generic Ethernet Switch port"
> * Remove most properties from ethernet-switch-port.yaml. They're
> all in ethernet-controller, and are all allowed.
> * ethernet-switch.yaml now only references ethernet-switch-port.yaml#
> under the port node.
>
> v1 -> v2
> * Remove accidental addition of
> "$ref: /schemas/net/ethernet-switch-port.yaml" which should be kept
> out of dsa-port so that it doesn't get referenced multiple times
> through both ethernet-switch and dsa-port.
>
> ---
> .../devicetree/bindings/net/dsa/dsa-port.yaml | 24 ++----------------
> .../bindings/net/ethernet-switch-port.yaml | 25 +++++++++++++++++++
> .../bindings/net/ethernet-switch.yaml | 6 +----
> MAINTAINERS | 1 +
> 4 files changed, 29 insertions(+), 27 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/net/ethernet-switch-port.yaml
>

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>