Re: [Patch V1 2/7] x86/microcode/intel: Remove retries on early microcode load

From: Ashok Raj
Date: Mon Dec 05 2022 - 11:45:10 EST


On Mon, Dec 05, 2022 at 01:18:58PM +0100, Borislav Petkov wrote:
> On Tue, Nov 29, 2022 at 01:08:27PM -0800, Ashok Raj wrote:
> > There is no direct evidence that these end user issues were caused by this
> > retry loop. However, the early boot hangs along with reverting the
> > microcode update workaround provide strong circumstantial evidence to
> > support the theory that they are linked.
>
> A "circumstantial" reason for why something "might" be broken has no
> place in a commit message.
>
> If you still wanna chase this and *actually* give me a sane,
> comprehensible reason of why this could cause an endless loop with
> officially released microcode, then I'm willing to listen.

Your changes look fine, thanks for fixing it up.

>
> Otherwise, I'll apply this:
>

Cheers,
Ashok