Re: [PATCH v6 2/2] EDAC/zynqmp: Add EDAC support for Xilinx ZynqMP OCM

From: Michal Simek
Date: Mon Dec 05 2022 - 09:49:56 EST




On 12/5/22 14:16, Borislav Petkov wrote:
On Mon, Dec 05, 2022 at 10:20:11AM +0000, Potthuri, Sai Krishna wrote:
As we communicated earlier for ZynqMP platform we have both Synopsys
(for DDRMC) and zynqmp_ocm_edac (for OCM) drivers. Just to be clear
about what this driver is targeted for, we used ocm as part of file
name. Ok, zynqmp_edac.c looks fine, will update.

Yeah, we can always rename later, when another driver is needed. For
now, let's keep things simple.

Ok, will update API documentation like below.
echo <fault_injection count> > /sys/kernel/debug/edac/ff960000.memory-controller/inject_fault_count
^^^^^^^^^^^^^^^^^^^^^^^^^^

Any particular reason this should not be called simply "mc0" or so?

At least this is how we call them on x86...

Some history around this. Based on
https://github.com/devicetree-org/devicetree-specification/releases/download/v0.3/devicetree-specification-v0.3.pdf
Chapter 2.2.2 Generic Names Recommendation
memory-controller name is recommended.

Thanks,
Michal